Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add MeshPhysicalMaterial.transparency. #18695

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 20, 2020

see #18680.

I'm not 100% sure about the description but I think it should be okay.

@WestLangley Since you have implemented #17114: Is there anything else we want to highlight in the docs? Or maybe write differently?

@mrdoob mrdoob added this to the r114 milestone Feb 20, 2020
@WestLangley
Copy link
Collaborator

I would keep it simple, like so -- at least for now.

<h3>[property:Float transparency]</h3>
<p>
Degree of transparency, from *0.0* to *1.0*. Default is *0.0*.<br />

Thin, transparent or semitransparent, plastic or glass materials remain largely reflective even if they are mostly transparent.

The transparency property can be used to model these materials.<br />

When transparency is non-zero, [page:Material.opacity opacity] should be set to *1*.
</p>

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 21, 2020

Okay, updated the PR with your suggestion!

@mrdoob mrdoob merged commit b559213 into mrdoob:dev Feb 22, 2020
@mrdoob
Copy link
Owner

mrdoob commented Feb 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants